database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-09-09 13:09:39 +03:00
Code Activity

compute_bitmap_pages' loop_count parameter should be double not int.

Browse Source 
The value was double in the original implementation of this logic.
Commit da08a6598 pulled it out into a subroutine, but carelessly
declared the parameter as int when it should have been double.
On most platforms, the only ill effect would be to clamp the value
to be not more than INT_MAX, which would seldom be exceeded and
probably wouldn't change the estimates too much anyway.  Nonetheless,
it's wrong and can cause complaints from ubsan.

While here, improve the comments and parameter names.

This is an ABI change in a globally exposed subroutine, so
back-patching would create some risk of breaking extensions.
The value of the fix doesn't seem high enough to warrant taking
that risk, so fix in HEAD only.

Per report from Alexander Lakhin.

Discussion: https://postgr.es/m/f5e15fe1-202d-1936-f47c-f0c69a936b72@gmail.com
This commit is contained in:
Tom Lane
2023-12-18 12:46:07 -05:00
parent 64b1fb5f03
commit 8b965c549d
2 changed files with 17 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
src/backend/optimizer/path/costsize.c
View File

@@ -6393,12 +6393,20 @@ get_parallel_divisor(Path *path)
/*
* compute_bitmap_pages
* Estimate number of pages fetched from heap in a bitmap heap scan.
*
* compute number of pages fetched from heap in bitmap heap scan.
* 'baserel' is the relation to be scanned
* 'bitmapqual' is a tree of IndexPaths, BitmapAndPaths, and BitmapOrPaths
* 'loop_count' is the number of repetitions of the indexscan to factor into
* estimates of caching behavior
*
* If cost_p isn't NULL, the indexTotalCost estimate is returned in *cost_p.
* If tuples_p isn't NULL, the tuples_fetched estimate is returned in *tuples_p.
*/
double
compute_bitmap_pages(PlannerInfo *root, RelOptInfo *baserel, Path *bitmapqual,
int loop_count, Cost *cost, double *tuple)
compute_bitmap_pages(PlannerInfo *root, RelOptInfo *baserel,
Path *bitmapqual, double loop_count,
Cost *cost_p, double *tuples_p)
{
Cost indexTotalCost;
Selectivity indexSelectivity;
@@ -6488,10 +6496,10 @@ compute_bitmap_pages(PlannerInfo *root, RelOptInfo *baserel, Path *bitmapqual,
(lossy_pages / heap_pages) * baserel->tuples);
}
if (cost)
*cost = indexTotalCost;
if (tuple)
*tuple = tuples_fetched;
if (cost_p)
*cost_p = indexTotalCost;
if (tuples_p)
*tuples_p = tuples_fetched;
return pages_fetched;
}