database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-11-07 19:06:32 +03:00
Code Activity

Fix CREATE INDEX CONCURRENTLY for simultaneous prepared transactions.

Browse Source 
In a cluster having used CREATE INDEX CONCURRENTLY while having enabled
prepared transactions, queries that use the resulting index can silently
fail to find rows.  Fix this for future CREATE INDEX CONCURRENTLY by
making it wait for prepared transactions like it waits for ordinary
transactions.  This expands the VirtualTransactionId structure domain to
admit prepared transactions.  It may be necessary to reindex to recover
from past occurrences.  Back-patch to 9.5 (all supported versions).

Andrey Borodin, reviewed (in earlier versions) by Tom Lane and Michael
Paquier.

Discussion: https://postgr.es/m/2E712143-97F7-4890-B470-4A35142ABC82@yandex-team.ru
This commit is contained in:
Noah Misch
2021-01-30 00:00:27 -08:00
parent f77717b298
commit 8a54e12a38
7 changed files with 98 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/backend/storage/lmgr/lmgr.c
View File

@@ -904,8 +904,7 @@ WaitForLockersMultiple(List *locktags, LOCKMODE lockmode, bool progress)
/*
* Note: GetLockConflicts() never reports our own xid, hence we need not
* check for that. Also, prepared xacts are not reported, which is fine
* since they certainly aren't going to do anything anymore.
* check for that. Also, prepared xacts are reported and awaited.
*/
/* Finally wait for each such transaction to complete */