database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-11 20:28:21 +03:00
Code Activity

postgres_fdw: Disable batch insert when BEFORE ROW INSERT triggers exist.

Browse Source 
Previously, we allowed this, but such triggers might query the table to
insert into and act differently if the tuples that have already been
processed and prepared for insertion are not there, so disable it in
such cases.

Back-patch to v14 where batch insert was added.

Discussion: https://postgr.es/m/CAPmGK16_uPqsmgK0-LpLSUk54_BoK13bPrhxhfjSoSTVz414hA%40mail.gmail.com
This commit is contained in:
Etsuro Fujita
2022-04-21 15:30:02 +09:00
parent e4521841a1
commit 89d349b0a0
3 changed files with 53 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
contrib/postgres_fdw/postgres_fdw.c
View File

@ -2012,8 +2012,8 @@ postgresExecForeignBatchInsert(EState *estate,
* Determine the maximum number of tuples that can be inserted in bulk
*
* Returns the batch size specified for server or table. When batching is not
* allowed (e.g. for tables with AFTER ROW triggers or with RETURNING clause),
* returns 1.
* allowed (e.g. for tables with BEFORE/AFTER ROW triggers or with RETURNING
* clause), returns 1.
*/
static int
postgresGetForeignModifyBatchSize(ResultRelInfo *resultRelInfo)
@ -2042,10 +2042,19 @@ postgresGetForeignModifyBatchSize(ResultRelInfo *resultRelInfo)
else
batch_size = get_batch_size_option(resultRelInfo->ri_RelationDesc);
/* Disable batching when we have to use RETURNING. */
/*
* Disable batching when we have to use RETURNING or there are any
* BEFORE/AFTER ROW INSERT triggers on the foreign table.
*
* When there are any BEFORE ROW INSERT triggers on the table, we can't
* support it, because such triggers might query the table we're inserting
* into and act differently if the tuples that have already been processed
* and prepared for insertion are not there.
*/
if (resultRelInfo->ri_projectReturning != NULL ||
(resultRelInfo->ri_TrigDesc &&
resultRelInfo->ri_TrigDesc->trig_insert_after_row))
(resultRelInfo->ri_TrigDesc->trig_insert_before_row ||
resultRelInfo->ri_TrigDesc->trig_insert_after_row)))
return 1;
/*