database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-09-09 13:09:39 +03:00
Code Activity

Allow examine_simple_variable() to work on INSERT RETURNING Vars.

Browse Source 
Since commit 599b33b94, this function assumed that every RTE_RELATION
RangeTblEntry would have an associated RelOptInfo.  But that's not so:
we only build RelOptInfos for relations that are scanned by the query.
In particular the target of an INSERT won't have one, so that Vars
appearing in an INSERT ... RETURNING list will not have an associated
RelOptInfo.  This apparently wasn't a problem before commit f7816aec2
taught examine_simple_variable() to drill down into CTEs containing
INSERT RETURNING, but it is now.

To fix, add a fallback code path that gets the userid to use directly
from the RTEPermissionInfo associated with the RTE.  (Sadly, we must
have two code paths, because not every RTE has a RTEPermissionInfo
either.)

Per report from Alexander Lakhin.  No back-patch, since the case is
apparently unreachable before f7816aec2.

Discussion: https://postgr.es/m/608a4886-6c60-0f9e-97d5-591256bd4150@gmail.com
This commit is contained in:
Tom Lane
2024-01-08 11:48:44 -05:00
parent bea18b1c94
commit 89b69db82a
5 changed files with 56 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/backend/optimizer/util/relnode.c
View File

@@ -420,6 +420,19 @@ find_base_rel(PlannerInfo *root, int relid)
return NULL; /* keep compiler quiet */
}
/*
* find_base_rel_noerr
* Find a base or otherrel relation entry, returning NULL if there's none
*/
RelOptInfo *
find_base_rel_noerr(PlannerInfo *root, int relid)
{
/* use an unsigned comparison to prevent negative array element access */
if ((uint32) relid < (uint32) root->simple_rel_array_size)
return root->simple_rel_array[relid];
return NULL;
}
/*
* find_base_rel_ignore_join
* Find a base or otherrel relation entry, which must already exist.