database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-27 12:41:57 +03:00
Code Activity

Fix further fallout from EXPLAIN ANALYZE BUFFERS change

Browse Source 
c2a4078eb adjusted EXPLAIN ANALYZE to default the BUFFERS to ON.  This
(hopefully) fixes the last remaining issue with regression test failures
with -D RELCACHE_FORCE_RELEASE -D CATCACHE_FORCE_RELEASE builds, where
the planner accesses more buffers due to the cold caches.

Discussion: https://postgr.es/m/CAApHDvqLdzgz77JsE-yTki3w9UiKQ-uTMLRctazcu+99-ips3g@mail.gmail.com
This commit is contained in:
David Rowley
2024-12-12 09:50:00 +13:00
parent e8d5929428
commit 89988ac589
2 changed files with 16 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
contrib/pg_stat_statements/expected/level_tracking.out
View File

@ -903,13 +903,13 @@ SELECT pg_stat_statements_reset() IS NOT NULL AS t;
t t
(1 row) (1 row)
EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF) SELECT 100; EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF) SELECT 100;
QUERY PLAN QUERY PLAN
-------------------------------- --------------------------------
Result (actual rows=1 loops=1) Result (actual rows=1 loops=1)
(1 row) (1 row)
EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF) EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF)
DECLARE foocur CURSOR FOR SELECT * FROM stats_track_tab; DECLARE foocur CURSOR FOR SELECT * FROM stats_track_tab;
QUERY PLAN QUERY PLAN
----------------------------------------------------- -----------------------------------------------------
@ -918,11 +918,11 @@ EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF)
SELECT toplevel, calls, query FROM pg_stat_statements SELECT toplevel, calls, query FROM pg_stat_statements
ORDER BY query COLLATE "C"; ORDER BY query COLLATE "C";
toplevel | calls | query toplevel | calls | query
----------+-------+----------------------------------------------------------------- ----------+-------+------------------------------------------------------------------------------
t | 1 | EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF) + t | 1 | EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF) +
| | DECLARE foocur CURSOR FOR SELECT * FROM stats_track_tab | | DECLARE foocur CURSOR FOR SELECT * FROM stats_track_tab
t | 1 | EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF) SELECT $1 t | 1 | EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF) SELECT $1
f | 1 | SELECT $1 f | 1 | SELECT $1
f | 1 | SELECT * FROM stats_track_tab f | 1 | SELECT * FROM stats_track_tab
t | 1 | SELECT pg_stat_statements_reset() IS NOT NULL AS t t | 1 | SELECT pg_stat_statements_reset() IS NOT NULL AS t
@ -936,13 +936,13 @@ SELECT pg_stat_statements_reset() IS NOT NULL AS t;
t t
(1 row) (1 row)
EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF) SELECT 100; EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF) SELECT 100;
QUERY PLAN QUERY PLAN
-------------------------------- --------------------------------
Result (actual rows=1 loops=1) Result (actual rows=1 loops=1)
(1 row) (1 row)
EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF) EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF)
DECLARE foocur CURSOR FOR SELECT * FROM stats_track_tab; DECLARE foocur CURSOR FOR SELECT * FROM stats_track_tab;
QUERY PLAN QUERY PLAN
----------------------------------------------------- -----------------------------------------------------
@ -951,11 +951,11 @@ EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF)
SELECT toplevel, calls, query FROM pg_stat_statements SELECT toplevel, calls, query FROM pg_stat_statements
ORDER BY query COLLATE "C"; ORDER BY query COLLATE "C";
toplevel | calls | query toplevel | calls | query
----------+-------+----------------------------------------------------------------- ----------+-------+------------------------------------------------------------------------------
t | 1 | EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF) + t | 1 | EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF) +
| | DECLARE foocur CURSOR FOR SELECT * FROM stats_track_tab | | DECLARE foocur CURSOR FOR SELECT * FROM stats_track_tab
t | 1 | EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF) SELECT $1 t | 1 | EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF) SELECT $1
t | 1 | SELECT pg_stat_statements_reset() IS NOT NULL AS t t | 1 | SELECT pg_stat_statements_reset() IS NOT NULL AS t
(3 rows) (3 rows)

8
contrib/pg_stat_statements/sql/level_tracking.sql
View File

@ -175,8 +175,8 @@ SELECT toplevel, calls, query FROM pg_stat_statements
-- Explain analyze, all-level tracking. -- Explain analyze, all-level tracking.
SET pg_stat_statements.track = 'all'; SET pg_stat_statements.track = 'all';
SELECT pg_stat_statements_reset() IS NOT NULL AS t; SELECT pg_stat_statements_reset() IS NOT NULL AS t;
EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF) SELECT 100; EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF) SELECT 100;
EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF) EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF)
DECLARE foocur CURSOR FOR SELECT * FROM stats_track_tab; DECLARE foocur CURSOR FOR SELECT * FROM stats_track_tab;
SELECT toplevel, calls, query FROM pg_stat_statements SELECT toplevel, calls, query FROM pg_stat_statements
ORDER BY query COLLATE "C"; ORDER BY query COLLATE "C";
@ -184,8 +184,8 @@ SELECT toplevel, calls, query FROM pg_stat_statements
-- Explain analyze, top tracking. -- Explain analyze, top tracking.
SET pg_stat_statements.track = 'top'; SET pg_stat_statements.track = 'top';
SELECT pg_stat_statements_reset() IS NOT NULL AS t; SELECT pg_stat_statements_reset() IS NOT NULL AS t;
EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF) SELECT 100; EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF) SELECT 100;
EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF) EXPLAIN (ANALYZE, COSTS OFF, SUMMARY OFF, TIMING OFF, BUFFERS OFF)
DECLARE foocur CURSOR FOR SELECT * FROM stats_track_tab; DECLARE foocur CURSOR FOR SELECT * FROM stats_track_tab;
SELECT toplevel, calls, query FROM pg_stat_statements SELECT toplevel, calls, query FROM pg_stat_statements
ORDER BY query COLLATE "C"; ORDER BY query COLLATE "C";