database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-05 07:21:24 +03:00
Code Activity

Code cleanup inspired by recent resname bug report (doesn't fix the bug

Browse Source 
yet, though).  Avoid using nth() to fetch tlist entries; provide a
common routine get_tle_by_resno() to search a tlist for a particular
resno.  This replaces a couple uses of nth() and a dozen hand-coded
search loops.  Also, replace a few uses of nth(length-1, list) with
llast().
This commit is contained in:
Tom Lane
2003-08-11 20:46:47 +00:00
parent cae912d05b
commit 88381ade63
12 changed files with 161 additions and 316 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/backend/executor/execJunk.c
View File

@ -8,7 +8,7 @@
*
*
* IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/executor/execJunk.c,v 1.35 2003/08/04 02:39:58 momjian Exp $
* $Header: /cvsroot/pgsql/src/backend/executor/execJunk.c,v 1.36 2003/08/11 20:46:46 tgl Exp $
*
*-------------------------------------------------------------------------
*/
@ -185,10 +185,7 @@ ExecGetJunkAttribute(JunkFilter *junkfilter,
{
List *targetList;
List *t;
Resdom *resdom;
AttrNumber resno;
char *resname;
bool resjunk;
TupleDesc tupType;
HeapTuple tuple;
@ -202,11 +199,10 @@ ExecGetJunkAttribute(JunkFilter *junkfilter,
foreach(t, targetList)
{
TargetEntry *tle = lfirst(t);
Resdom *resdom = tle->resdom;
resdom = tle->resdom;
resname = resdom->resname;
resjunk = resdom->resjunk;
if (resjunk && (strcmp(resname, attrName) == 0))
if (resdom->resjunk && resdom->resname &&
(strcmp(resdom->resname, attrName) == 0))
{
/* We found it ! */
resno = resdom->resno;