database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-17 06:41:09 +03:00
Code Activity

Remove stray references to lefttree/righttree in the executor.

Browse Source 
The general convention in the executor is to refer to child plans
and planstates via the outerPlan[State] and innerPlan[State]
macros, but a few places didn't do it like that.  For consistency
and readability, convert all the stragglers to use the macros.
(See also commit 40f42d2a3, which did some similar cleanup a few
years ago, but missed these cases.)

Richard Guo

Discussion: https://postgr.es/m/CAMbWs4-vYhh1xsa_veah4PUed2Xq=Ed_YH3=Mqt5A3Y=EgfCEg@mail.gmail.com
This commit is contained in:
Tom Lane
2022-07-07 11:23:40 -04:00
parent 62c46eee22
commit 8821054210
14 changed files with 56 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/backend/executor/nodeResult.c
View File

@ -259,6 +259,8 @@ ExecEndResult(ResultState *node)
void
ExecReScanResult(ResultState *node)
{
PlanState *outerPlan = outerPlanState(node);
node->rs_done = false;
node->rs_checkqual = (node->resconstantqual != NULL);
@ -266,7 +268,6 @@ ExecReScanResult(ResultState *node)
* If chgParam of subnode is not null then plan will be re-scanned by
* first ExecProcNode.
*/
if (node->ps.lefttree &&
node->ps.lefttree->chgParam == NULL)
ExecReScan(node->ps.lefttree);
if (outerPlan && outerPlan->chgParam == NULL)
ExecReScan(outerPlan);
}