database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-12 21:01:52 +03:00
Code Activity

Remove stray references to lefttree/righttree in the executor.

Browse Source 
The general convention in the executor is to refer to child plans
and planstates via the outerPlan[State] and innerPlan[State]
macros, but a few places didn't do it like that.  For consistency
and readability, convert all the stragglers to use the macros.
(See also commit 40f42d2a3, which did some similar cleanup a few
years ago, but missed these cases.)

Richard Guo

Discussion: https://postgr.es/m/CAMbWs4-vYhh1xsa_veah4PUed2Xq=Ed_YH3=Mqt5A3Y=EgfCEg@mail.gmail.com
This commit is contained in:
Tom Lane
2022-07-07 11:23:40 -04:00
parent 62c46eee22
commit 8821054210
14 changed files with 56 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/backend/executor/nodeAgg.c
View File

@ -3388,7 +3388,7 @@ ExecInitAgg(Agg *node, EState *estate, int eflags)
if (phaseidx > 0)
{
aggnode = list_nth_node(Agg, node->chain, phaseidx - 1);
sortnode = castNode(Sort, aggnode->plan.lefttree);
sortnode = castNode(Sort, outerPlan(aggnode));
}
else
{