database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-14 18:42:34 +03:00
Code Activity

Improve wording of error message when a postgresql.conf setting is

Browse Source 
ignored because it can only be set at server start.  In particular,
hiding the main reason in the detail message was suboptimal.
This commit is contained in:
Peter Eisentraut
2009-09-17 21:15:18 +00:00
parent 41a40fe4a2
commit 87f4a26e5d
2 changed files with 8 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/backend/utils/misc/guc-file.l
View File

@ -4,7 +4,7 @@
* *
* Copyright (c) 2000-2009, PostgreSQL Global Development Group * Copyright (c) 2000-2009, PostgreSQL Global Development Group
* *
* $PostgreSQL: pgsql/src/backend/utils/misc/guc-file.l,v 1.60 2009/09/17 20:54:03 petere Exp $ * $PostgreSQL: pgsql/src/backend/utils/misc/guc-file.l,v 1.61 2009/09/17 21:15:18 petere Exp $
*/ */
%{ %{
@ -260,9 +260,8 @@ ProcessConfigFile(GucContext context)
{ {
ereport(elevel, ereport(elevel,
(errcode(ERRCODE_CANT_CHANGE_RUNTIME_PARAM), (errcode(ERRCODE_CANT_CHANGE_RUNTIME_PARAM),
errmsg("attempted change of parameter \"%s\" ignored", errmsg("parameter \"%s\" cannot be changed without restarting the server",
gconf->name), gconf->name)));
errdetail("This parameter cannot be changed after server start.")));
continue; continue;
} }

12
src/backend/utils/misc/guc.c
View File

@ -10,7 +10,7 @@
* Written by Peter Eisentraut <peter_e@gmx.net>. * Written by Peter Eisentraut <peter_e@gmx.net>.
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/utils/misc/guc.c,v 1.517 2009/09/11 19:17:03 tgl Exp $ * $PostgreSQL: pgsql/src/backend/utils/misc/guc.c,v 1.518 2009/09/17 21:15:18 petere Exp $
* *
*-------------------------------------------------------------------- *--------------------------------------------------------------------
*/ */
@ -4599,18 +4599,16 @@ set_config_option(const char *name, const char *value,
if (changeVal && !is_newvalue_equal(record, value)) if (changeVal && !is_newvalue_equal(record, value))
ereport(elevel, ereport(elevel,
(errcode(ERRCODE_CANT_CHANGE_RUNTIME_PARAM), (errcode(ERRCODE_CANT_CHANGE_RUNTIME_PARAM),
errmsg("attempted change of parameter \"%s\" ignored", errmsg("parameter \"%s\" cannot be changed without restarting the server",
name), name)));
errdetail("This parameter cannot be changed after server start.")));
return true; return true;
} }
if (context != PGC_POSTMASTER) if (context != PGC_POSTMASTER)
{ {
ereport(elevel, ereport(elevel,
(errcode(ERRCODE_CANT_CHANGE_RUNTIME_PARAM), (errcode(ERRCODE_CANT_CHANGE_RUNTIME_PARAM),
errmsg("attempted change of parameter \"%s\" ignored", errmsg("parameter \"%s\" cannot be changed without restarting the server",
name), name)));
errdetail("This parameter cannot be changed after server start.")));
return false; return false;
} }
break; break;