From 87efbc2be12b07c77b7fa2d54d029329f56d6677 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Thu, 10 Sep 2015 10:23:56 -0400 Subject: [PATCH] Fix setrefs.c comment properly. The "typo" alleged in commit 1e460d4bd was actually a comment that was correct when written, but I missed updating it in commit b5282aa89. Use a slightly less specific (and hopefully more future-proof) description of what is collected. Back-patch to 9.2 where that commit appeared, and revert the comment to its then-entirely-correct state before that. --- src/backend/optimizer/plan/setrefs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/optimizer/plan/setrefs.c b/src/backend/optimizer/plan/setrefs.c index 093d925553c..daeb5842d04 100644 --- a/src/backend/optimizer/plan/setrefs.c +++ b/src/backend/optimizer/plan/setrefs.c @@ -1243,7 +1243,7 @@ copyVar(Var *var) * This is code that is common to all variants of expression-fixing. * We must look up operator opcode info for OpExpr and related nodes, * add OIDs from regclass Const nodes into root->glob->relationOids, and - * add catalog OIDs for user-defined functions into root->glob->invalItems. + * add PlanInvalItems for user-defined functions into root->glob->invalItems. * We also fill in column index lists for GROUPING() expressions. * * We assume it's okay to update opcode info in-place. So this could possibly