database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-09-09 13:09:39 +03:00
Code Activity

Move memory barrier in UnlockBufHdr to before releasing the lock.

Browse Source 
This bug appears to have been introduced late in the development of
48354581a4 ("Allow Pin/UnpinBuffer to operate in a lockfree
manner.").

Found while debugging a bug which turned out to be independent of the
commit mentioned above.

Backpatch: -
This commit is contained in:
Andres Freund
2016-05-30 15:35:53 -07:00
parent 975ad4e602
commit 87a3023c60
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/include/storage/buf_internals.h
View File

@@ -242,8 +242,8 @@ extern PGDLLIMPORT LWLockMinimallyPadded *BufferIOLWLockArray;
extern uint32 LockBufHdr(BufferDesc *desc); extern uint32 LockBufHdr(BufferDesc *desc);
#define UnlockBufHdr(desc, s) \ #define UnlockBufHdr(desc, s) \
do { \ do { \
pg_atomic_write_u32(&(desc)->state, (s) & (~BM_LOCKED)); \
pg_write_barrier(); \ pg_write_barrier(); \
pg_atomic_write_u32(&(desc)->state, (s) & (~BM_LOCKED)); \
} while (0) } while (0)