database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-30 11:03:19 +03:00
Code Activity

Fix dblink_build_sql_insert() and related functions to handle dropped

Browse Source 
columns correctly.  In passing, get rid of some dead logic in the
underlying get_sql_insert() etc functions --- there is no caller that
will pass null value-arrays to them.

Per bug report from Robert Voinea.
This commit is contained in:
Tom Lane
2010-06-15 19:04:59 +00:00
parent 240076b3c4
commit 873b9b8a3d
3 changed files with 97 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
contrib/dblink/sql/dblink.sql
View File

@ -244,3 +244,28 @@ SELECT dblink_disconnect('myconn');
-- close the named persistent connection again
-- should get 'connection "myconn" not available' error
SELECT dblink_disconnect('myconn');
-- test dropped columns in dblink_build_sql_insert, dblink_build_sql_update
CREATE TEMP TABLE test_dropped
(
col1 INT NOT NULL DEFAULT 111,
id SERIAL PRIMARY KEY,
col2 INT NOT NULL DEFAULT 112,
col2b INT NOT NULL DEFAULT 113
);
ALTER TABLE test_dropped DROP COLUMN col1;
ALTER TABLE test_dropped DROP COLUMN col2;
ALTER TABLE test_dropped ADD COLUMN col3 VARCHAR(10);
ALTER TABLE test_dropped ADD COLUMN col4 INT;
INSERT INTO test_dropped VALUES(default,default,'foo','42');
SELECT dblink_build_sql_insert('test_dropped', '2', 1,
ARRAY['1'::TEXT], ARRAY['2'::TEXT]);
SELECT dblink_build_sql_update('test_dropped', '2', 1,
ARRAY['1'::TEXT], ARRAY['2'::TEXT]);
SELECT dblink_build_sql_delete('test_dropped', '2', 1,
ARRAY['2'::TEXT]);