database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-05-05 09:19:17 +03:00
Code

Don't start to stream after pg_receivexlog --create-slot.

Browse Source 
Immediately starting to stream after --create-slot is inconvenient in a
number of situations (e.g. when configuring a slot for use in
recovery.conf) and it's easy to just call pg_receivexlog twice in the
rest of the cases.

Author: Michael Paquier
Discussion: CAB7nPqQ9qEtuDiKY3OpNzHcz5iUA+DUX9FcN9K8GUkCZvG7+Ew@mail.gmail.com
Backpatch: 9.5, where the option was introduced
This commit is contained in:
Andres Freund 2015-08-10 13:28:19 +02:00
parent 6e03d476c9
commit 86baf3c24d
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
doc/src/sgml/ref/pg_receivexlog.sgml
View File

@ -273,7 +273,7 @@ PostgreSQL documentation
<listitem> <listitem>
<para> <para>
Create a new physical replication slot with the name specified in Create a new physical replication slot with the name specified in
<option>--slot</option>, then start to stream WAL. <option>--slot</option>, then exit.
</para> </para>
</listitem> </listitem>
</varlistentry> </varlistentry>

5
src/bin/pg_basebackup/pg_receivexlog.c
View File

@ -508,7 +508,7 @@ main(int argc, char **argv)
/* /*
* Required arguments * Required arguments
*/ */
if (basedir == NULL && !do_drop_slot) if (basedir == NULL && !do_drop_slot && !do_create_slot)
{ {
fprintf(stderr, _("%s: no target directory specified\n"), progname); fprintf(stderr, _("%s: no target directory specified\n"), progname);
fprintf(stderr, _("Try \"%s --help\" for more information.\n"), fprintf(stderr, _("Try \"%s --help\" for more information.\n"),
@ -519,7 +519,7 @@ main(int argc, char **argv)
/* /*
* Check existence of destination folder. * Check existence of destination folder.
*/ */
if (!do_drop_slot) if (!do_drop_slot && !do_create_slot)
{ {
DIR *dir = get_destination_dir(basedir); DIR *dir = get_destination_dir(basedir);
@ -584,6 +584,7 @@ main(int argc, char **argv)
if (!CreateReplicationSlot(conn, replication_slot, NULL, true, if (!CreateReplicationSlot(conn, replication_slot, NULL, true,
slot_exists_ok)) slot_exists_ok))
disconnect_and_exit(1); disconnect_and_exit(1);
disconnect_and_exit(0);
} }
/* /*