database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-02 09:02:37 +03:00
Code Activity

Clean up handling of dropped columns in NAMEDTUPLESTORE RTEs.

Browse Source 
The NAMEDTUPLESTORE patch piggybacked on the infrastructure for
TABLEFUNC/VALUES/CTE RTEs, none of which can ever have dropped columns,
so the possibility was ignored most places.  Fix that, including adding a
specification to parsenodes.h about what it's supposed to look like.

In passing, clean up assorted comments that hadn't been maintained
properly by said patch.

Per bug #14799 from Philippe Beaudoin.  Back-patch to v10.

Discussion: https://postgr.es/m/20170906120005.25630.84360@wrigleys.postgresql.org
This commit is contained in:
Tom Lane
2017-09-06 10:41:05 -04:00
parent 0b554e4e63
commit 8689e38263
5 changed files with 77 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/backend/utils/adt/ruleutils.c
View File

@ -6846,8 +6846,8 @@ get_name_for_var_field(Var *var, int fieldno,
case RTE_NAMEDTUPLESTORE:
/*
* This case should not occur: a column of a table or values list
* shouldn't have type RECORD. Fall through and fail (most
* This case should not occur: a column of a table, values list,
* or ENR shouldn't have type RECORD. Fall through and fail (most
* likely) at the bottom.
*/
break;