database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-27 12:41:57 +03:00
Code Activity

pgcrypto: Report errant decryption as "Wrong key or corrupt data".

Browse Source 
This has been the predominant outcome.  When the output of decrypting
with a wrong key coincidentally resembled an OpenPGP packet header,
pgcrypto could instead report "Corrupt data", "Not text data" or
"Unsupported compression algorithm".  The distinct "Corrupt data"
message added no value.  The latter two error messages misled when the
decrypted payload also exhibited fundamental integrity problems.  Worse,
error message variance in other systems has enabled cryptologic attacks;
see RFC 4880 section "14. Security Considerations".  Whether these
pgcrypto behaviors are likewise exploitable is unknown.

In passing, document that pgcrypto does not resist side-channel attacks.
Back-patch to 9.0 (all supported versions).

Security: CVE-2015-3167
This commit is contained in:
Noah Misch
2015-05-18 10:02:31 -04:00
parent fd97bd411d
commit 85270ac7a2
9 changed files with 162 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
contrib/pgcrypto/pgp.h
View File

@ -153,7 +153,9 @@ struct PGP_Context
* internal variables
*/
int mdc_checked;
int corrupt_prefix;
int corrupt_prefix; /* prefix failed RFC 4880 "quick check" */
int unsupported_compr; /* has bzip2 compression */
int unexpected_binary; /* binary data seen in text_mode */
int in_mdc_pkt;
int use_mdcbuf_filter;
PX_MD *mdc_ctx;