From 846fb3c7901146a5450c08aeadf50566d5d65d09 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Thu, 22 Jan 2026 12:41:40 +0100 Subject: [PATCH] Remove incorrect commented out code These calls, if activated, are happening before null checks, so they are not correct. Also, the "in" variable is shadowed later. Remove them to avoid confusion and bad examples. Reviewed-by: Heikki Linnakangas Reviewed-by: David Geier Discussion: https://www.postgresql.org/message-id/flat/328e4371-9a4c-4196-9df9-1f23afc900df%40eisentraut.org --- src/backend/utils/adt/jsonfuncs.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/backend/utils/adt/jsonfuncs.c b/src/backend/utils/adt/jsonfuncs.c index f2f1f59013a..1e5b60801e4 100644 --- a/src/backend/utils/adt/jsonfuncs.c +++ b/src/backend/utils/adt/jsonfuncs.c @@ -4898,10 +4898,6 @@ jsonb_set(PG_FUNCTION_ARGS) Datum jsonb_set_lax(PG_FUNCTION_ARGS) { - /* Jsonb *in = PG_GETARG_JSONB_P(0); */ - /* ArrayType *path = PG_GETARG_ARRAYTYPE_P(1); */ - /* Jsonb *newval = PG_GETARG_JSONB_P(2); */ - /* bool create = PG_GETARG_BOOL(3); */ text *handle_null; char *handle_val;