database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-13 07:41:39 +03:00
Code Activity

Fixup various StringInfo function usages

Browse Source 
This adjusts various appendStringInfo* function calls to use a more
appropriate and efficient function with the same behavior.  For example,
use appendStringInfoChar() when appending a single character rather than
appendStringInfo() and appendStringInfoString() when no formatting is
required rather than using appendStringInfo().

All adjustments made here are in code that's new to v17, so it makes
sense to fix these now rather than wait a few years and make
backpatching harder.

Discussion: https://postgr.es/m/CAApHDvojY2UvMiO+9_55ArTj10P1LBNJyyoGB+C65BLDNT0GsQ@mail.gmail.com
Reviewed-by: Nathan Bossart, Tom Lane
This commit is contained in:
David Rowley
2024-04-10 11:53:32 +12:00
parent ff9f72c68f
commit 8461424fd7
5 changed files with 18 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
contrib/postgres_fdw/deparse.c
View File

@ -1887,7 +1887,7 @@ deparseFromExprForRel(StringInfo buf, PlannerInfo *root, RelOptInfo *foreignrel,
}
/* Close parentheses for EXISTS subquery */
appendStringInfo(&str, ")");
appendStringInfoChar(&str, ')');
*additional_conds = lappend(*additional_conds, str.data);
}
@ -1921,7 +1921,7 @@ deparseFromExprForRel(StringInfo buf, PlannerInfo *root, RelOptInfo *foreignrel,
*/
if (fpinfo->jointype == JOIN_SEMI)
{
appendStringInfo(buf, "%s", join_sql_o.data);
appendBinaryStringInfo(buf, join_sql_o.data, join_sql_o.len);
}
else
{