database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-10-16 17:07:43 +03:00
Code Activity

Remove overzealous _bt_killitems assertion.

Browse Source 
An assertion in _bt_killitems expected the scan's currPos state to
contain a valid LSN, saved from when currPos's page was initially read.
The assertion failed to account for the fact that even logged relations
can have leaf pages with an invalid LSN when built with wal_level set to
"minimal".  Remove the faulty assertion.

Oversight in commit e6eed40e (though note that the assertion was
backpatched to stable branches before 18 by commit 7c319f54).

Author: Peter Geoghegan <pg@bowt.ie>
Reported-By: Matthijs van der Vleuten <postgresql@zr40.nl>
Bug: #19082
Discussion: https://postgr.es/m/19082-628e62160dbbc1c1@postgresql.org
Backpatch-through: 13
This commit is contained in:
Peter Geoghegan
2025-10-10 14:52:25 -04:00
parent 3a36543d7d
commit 843e50208a
1 changed files with 0 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/backend/access/nbtree/nbtutils.c
View File

@@ -3397,7 +3397,6 @@ _bt_killitems(IndexScanDesc scan)
buf = _bt_getbuf(rel, so->currPos.currPage, BT_READ);
latestlsn = BufferGetLSNAtomic(buf);
Assert(!XLogRecPtrIsInvalid(so->currPos.lsn));
Assert(so->currPos.lsn <= latestlsn);
if (so->currPos.lsn != latestlsn)
{