database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-30 21:42:05 +03:00
Code Activity

Actually, instead of whining about how type internal might not safely store

Browse Source 
a pointer, why don't we just fix that.  Every known use of "internal" really
means a pointer anyway.
This commit is contained in:
Tom Lane
2008-11-14 02:09:52 +00:00
parent 03e5248d0f
commit 81e11f2d05
4 changed files with 16 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/backend/utils/adt/array_userfuncs.c
View File

@ -6,7 +6,7 @@
* Copyright (c) 2003-2008, PostgreSQL Global Development Group
*
* IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/utils/adt/array_userfuncs.c,v 1.25 2008/11/14 00:12:08 tgl Exp $
* $PostgreSQL: pgsql/src/backend/utils/adt/array_userfuncs.c,v 1.26 2008/11/14 02:09:51 tgl Exp $
*
*-------------------------------------------------------------------------
*/
@ -495,14 +495,10 @@ array_agg_transfn(PG_FUNCTION_ARGS)
((AggState *) fcinfo->context)->aggcontext);
/*
* We cheat quite a lot here by assuming that a pointer datum will be
* preserved intact when nodeAgg.c thinks it is a value of type "internal".
* This will in fact work because internal is stated to be pass-by-value
* in pg_type.h, and nodeAgg will never do anything with a pass-by-value
* transvalue except pass it around in Datum form. But it's mighty
* shaky seeing that internal is also stated to be 4 bytes wide in
* pg_type.h. If nodeAgg did put the value into a tuple this would
* crash and burn on 64-bit machines.
* The transition type for array_agg() is declared to be "internal",
* which is a pass-by-value type the same size as a pointer. So we
* can safely pass the ArrayBuildState pointer through nodeAgg.c's
* machinations.
*/
PG_RETURN_POINTER(state);
}