database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-29 10:41:53 +03:00
Code Activity

Fix lc_collate_is_c() when LC_COLLATE != LC_CTYPE.

Browse Source 
An unfortunate typo in commit 2d819a08a1 can cause wrong results when
the default collation provider is libc, LC_CTYPE=C, and LC_COLLATE is
a real locale. Users with this combination of settings must REINDEX
all affected indexes.

The same typo can also cause performance degradation when LC_COLLATE=C
and LC_CTYPE is a real locale.

Problem does not exist in master (due to refactoring), so fix only in
version 17.

Reported-by: Drew Callahan
Discussion: https://postgr.es/m/d5081a7f4f6d425c28dd69d1e09b2e78f149e726.camel@j-davis.com
This commit is contained in:
Jeff Davis
2024-11-06 14:44:35 -08:00
parent b7467ab71c
commit 8148e7124d
1 changed files with 2 additions and 2 deletions

4
src/backend/utils/adt/pg_locale.c

@ -1370,9 +1370,9 @@ lc_collate_is_c(Oid collation)
} }
else if (default_locale.provider == COLLPROVIDER_LIBC) else if (default_locale.provider == COLLPROVIDER_LIBC)
{ {
localeptr = setlocale(LC_CTYPE, NULL); localeptr = setlocale(LC_COLLATE, NULL);
if (!localeptr) if (!localeptr)
elog(ERROR, "invalid LC_CTYPE setting"); elog(ERROR, "invalid LC_COLLATE setting");
} }
else else
elog(ERROR, "unexpected collation provider '%c'", elog(ERROR, "unexpected collation provider '%c'",