database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-08-05 07:41:25 +03:00
Code Activity

Remove superfluous autoprewarm check

Browse Source 
autoprewarm_database_main() prewarms blocks from the same database. It
is passed an array of sorted BlockInfoRecords and a start and stop index
into the array. The range represented should include only blocks
belonging to global objects or blocks from a single database. Remove an
unnecessary check that the current block is from the same database and
add an assert to ensure this invariant remains. Doing so removes a
special case that makes future refactoring to accommodate read
streamifying autoprewarm easier.

Noticed off-list by Andres Freund
This commit is contained in:
Melanie Plageman
2025-04-04 15:25:17 -04:00
parent b3f1a13f22
commit 7f848cb788
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
contrib/pg_prewarm/autoprewarm.c
View File

@@ -463,12 +463,10 @@ autoprewarm_database_main(Datum main_arg)
CHECK_FOR_INTERRUPTS(); CHECK_FOR_INTERRUPTS();
/* /*
* Quit if we've reached records for another database. If previous * All blocks between prewarm_start_idx and prewarm_stop_idx should
* blocks are of some global objects, then continue pre-warming. * belong either to global objects or the same database.
*/ */
if (old_blk != NULL && old_blk->database != blk->database && Assert(blk->database == apw_state->database || blk->database == 0);
old_blk->database != 0)
break;
/* /*
* As soon as we encounter a block of a new relation, close the old * As soon as we encounter a block of a new relation, close the old