database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-11-19 13:42:17 +03:00
Code Activity

Use consistent style for checking return from system calls

Browse Source 
Use

    if (something() != 0)
        error ...

instead of just

    if (something)
        error ...

The latter is not incorrect, but it's a bit confusing and not the
common style.

Discussion: https://www.postgresql.org/message-id/flat/5de61b6b-8be9-7771-0048-860328efe027%402ndquadrant.com
This commit is contained in:
Peter Eisentraut
2019-07-06 23:18:46 +02:00
parent d1a040543b
commit 7e9a4c5c3d
19 changed files with 45 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/backend/utils/cache/relmapper.c vendored
View File

@@ -747,7 +747,7 @@ load_relmap_file(bool shared)
}
pgstat_report_wait_end();
if (CloseTransientFile(fd))
if (CloseTransientFile(fd) != 0)
ereport(FATAL,
(errcode_for_file_access(),
errmsg("could not close file \"%s\": %m",
@@ -886,7 +886,7 @@ write_relmap_file(bool shared, RelMapFile *newmap,
mapfilename)));
pgstat_report_wait_end();
if (CloseTransientFile(fd))
if (CloseTransientFile(fd) != 0)
ereport(ERROR,
(errcode_for_file_access(),
errmsg("could not close file \"%s\": %m",