database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-05 07:21:24 +03:00
Code Activity

Fix oversight in join removal patch: we have to delete the removed relation

Browse Source 
from SpecialJoinInfo relid sets as well.  Per example from Vaclav Novotny.
This commit is contained in:
Tom Lane
2010-05-23 16:34:38 +00:00
parent c8518845de
commit 7df4cf7fd3
3 changed files with 39 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/backend/optimizer/plan/analyzejoins.c
View File

@ -16,7 +16,7 @@
*
*
* IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/optimizer/plan/analyzejoins.c,v 1.1 2010/03/28 22:59:32 tgl Exp $
* $PostgreSQL: pgsql/src/backend/optimizer/plan/analyzejoins.c,v 1.2 2010/05/23 16:34:38 tgl Exp $
*
*-------------------------------------------------------------------------
*/
@ -343,6 +343,24 @@ remove_rel_from_query(PlannerInfo *root, int relid)
}
}
/*
* Likewise remove references from SpecialJoinInfo data structures.
*
* This is relevant in case the outer join we're deleting is nested
* inside other outer joins: the upper joins' relid sets have to be
* adjusted. The RHS of the target outer join will be made empty here,
* but that's OK since caller will delete that SpecialJoinInfo entirely.
*/
foreach(l, root->join_info_list)
{
SpecialJoinInfo *sjinfo = (SpecialJoinInfo *) lfirst(l);
sjinfo->min_lefthand = bms_del_member(sjinfo->min_lefthand, relid);
sjinfo->min_righthand = bms_del_member(sjinfo->min_righthand, relid);
sjinfo->syn_lefthand = bms_del_member(sjinfo->syn_lefthand, relid);
sjinfo->syn_righthand = bms_del_member(sjinfo->syn_righthand, relid);
}
/*
* Likewise remove references from PlaceHolderVar data structures.
*