database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-11-25 12:03:53 +03:00
Code Activity

pg_buffercache: Remove unused fields from BufferCacheNumaRec

Browse Source 
These fields have been added in commit ba2a3c2302, and have never been
used.  While on it, this commit moves a comment that was out of place,
improving it.

Author: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Discussion: https://postgr.es/m/aSBOKX6pLJzumbmF@ip-10-97-1-34.eu-west-3.compute.internal
This commit is contained in:
Michael Paquier
2025-11-23 13:37:42 +09:00
parent b140c8d7a3
commit 7d9043aee8
1 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
contrib/pg_buffercache/pg_buffercache_pages.c
View File

@@ -82,9 +82,6 @@ typedef struct
typedef struct typedef struct
{ {
TupleDesc tupdesc; TupleDesc tupdesc;
int buffers_per_page;
int pages_per_buffer;
int os_page_size;
BufferCacheNumaRec *record; BufferCacheNumaRec *record;
} BufferCacheNumaContext; } BufferCacheNumaContext;
@@ -368,7 +365,12 @@ pg_buffercache_numa_pages(PG_FUNCTION_ARGS)
os_page_ptrs = palloc0(sizeof(void *) * os_page_count); os_page_ptrs = palloc0(sizeof(void *) * os_page_count);
os_page_status = palloc(sizeof(uint64) * os_page_count); os_page_status = palloc(sizeof(uint64) * os_page_count);
/* Fill pointers for all the memory pages. */ /*
* Fill pointers for all the memory pages. This loop stores and
* touches (if needed) addresses into os_page_ptrs[] as input to one
* big move_pages(2) inquiry system call, as done in
* pg_numa_query_pages().
*/
idx = 0; idx = 0;
for (char *ptr = startptr; ptr < endptr; ptr += os_page_size) for (char *ptr = startptr; ptr < endptr; ptr += os_page_size)
{ {
@@ -449,10 +451,6 @@ pg_buffercache_numa_pages(PG_FUNCTION_ARGS)
* We don't hold the partition locks, so we don't get a consistent * We don't hold the partition locks, so we don't get a consistent
* snapshot across all buffers, but we do grab the buffer header * snapshot across all buffers, but we do grab the buffer header
* locks, so the information of each buffer is self-consistent. * locks, so the information of each buffer is self-consistent.
*
* This loop touches and stores addresses into os_page_ptrs[] as input
* to one big move_pages(2) inquiry system call. Basically we ask for
* all memory pages for NBuffers.
*/ */
startptr = (char *) TYPEALIGN_DOWN(os_page_size, (char *) BufferGetBlock(1)); startptr = (char *) TYPEALIGN_DOWN(os_page_size, (char *) BufferGetBlock(1));
idx = 0; idx = 0;