From 7d60e4183013c8b1316daf4ec0d08ef245d3b92c Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Sun, 6 Sep 2020 11:50:41 -0400 Subject: [PATCH] Remove useless lstat() call in pg_rewind. This is duplicative of an lstat that was just done by the calling function (traverse_datadir), besides which we weren't really doing anything with the results. There's not much point in checking to see if someone removed the file since the previous lstat, since the FILE_ACTION_REMOVE code would have to deal with missing-file cases anyway. Moreover, the "exists = false" assignment was a dead store; nothing was done with that value later. A syscall saved is a syscall earned, so back-patch to 9.5 where this code was introduced. Discussion: https://postgr.es/m/1221796.1599329320@sss.pgh.pa.us --- src/bin/pg_rewind/filemap.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/src/bin/pg_rewind/filemap.c b/src/bin/pg_rewind/filemap.c index 6a7634ef542..b174db7ccc9 100644 --- a/src/bin/pg_rewind/filemap.c +++ b/src/bin/pg_rewind/filemap.c @@ -253,23 +253,11 @@ process_target_file(const char *path, file_type_t type, size_t oldsize, const char *link_target) { bool exists; - char localpath[MAXPGPATH]; - struct stat statbuf; file_entry_t key; file_entry_t *key_ptr; filemap_t *map = filemap; file_entry_t *entry; - snprintf(localpath, sizeof(localpath), "%s/%s", datadir_target, path); - if (lstat(localpath, &statbuf) < 0) - { - if (errno != ENOENT) - pg_fatal("could not stat file \"%s\": %s\n", - localpath, strerror(errno)); - - exists = false; - } - if (map->array == NULL) { /* on first call, initialize lookup array */