database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-11-10 17:42:29 +03:00
Code Activity

Make acl-related functions safe for TOAST. Mark pg_class.relacl as

Browse Source 
compressible but not externally storable (since we're not sure about
whether creating a toast relation for pg_class would work).
This commit is contained in:
Tom Lane
2000-07-31 22:39:17 +00:00
parent b7319d3717
commit 7d0c4188f1
7 changed files with 195 additions and 176 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/backend/access/heap/tuptoaster.c
View File

@@ -8,7 +8,7 @@
*
*
* IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/access/heap/tuptoaster.c,v 1.9 2000/07/22 11:18:46 wieck Exp $
* $Header: /cvsroot/pgsql/src/backend/access/heap/tuptoaster.c,v 1.10 2000/07/31 22:39:17 tgl Exp $
*
*
* INTERFACE ROUTINES
@@ -273,7 +273,7 @@ toast_insert_or_update(Relation rel, HeapTuple newtup, HeapTuple oldtup)
/* ----------
* If the old value is an external stored one, check if it
* has changed so we have to detele it later.
* has changed so we have to delete it later.
* ----------
*/
if (!old_isnull && att[i]->attlen == -1 &&
@@ -336,17 +336,16 @@ toast_insert_or_update(Relation rel, HeapTuple newtup, HeapTuple oldtup)
if (att[i]->attlen == -1)
{
/* ----------
* If the tables attribute say's PLAIN allways, we
* do so below.
* If the table's attribute says PLAIN always, force it so.
* ----------
*/
if (att[i]->attstorage == 'p')
toast_action[i] = 'p';
/* ----------
* We're running for UPDATE, so any TOASTed value we find
* still in the tuple must be someone elses we cannot reuse.
* Expand it to plain and eventually toast it again below.
* We took care of UPDATE above, so any TOASTed value we find
* still in the tuple must be someone else's we cannot reuse.
* Expand it to plain (and, probably, toast it again below).
* ----------
*/
if (VARATT_IS_EXTENDED(DatumGetPointer(toast_values[i])))
@@ -367,7 +366,7 @@ toast_insert_or_update(Relation rel, HeapTuple newtup, HeapTuple oldtup)
else
{
/* ----------
* Not a variable size attribute, plain storage allways
* Not a variable size attribute, plain storage always
* ----------
*/
toast_action[i] = 'p';