1
0
mirror of https://github.com/postgres/postgres.git synced 2025-10-22 14:32:25 +03:00

Fix for aggregate memory leaks from Erik Riedel.

This commit is contained in:
Bruce Momjian
1999-03-20 01:13:22 +00:00
parent 9ede867281
commit 7d0ab659ac
4 changed files with 76 additions and 4 deletions

View File

@@ -110,6 +110,7 @@ ExecAgg(Agg *node)
isNull2 = FALSE;
bool qual_result;
Datum oldVal = (Datum) NULL; /* XXX - so that we can save and free on each iteration - er1p */
/* ---------------------
* get state info from node
@@ -372,8 +373,10 @@ ExecAgg(Agg *node)
*/
args[0] = value1[aggno];
args[1] = newVal;
oldVal = value1[aggno]; /* XXX - save so we can free later - er1p */
value1[aggno] = (Datum) fmgr_c(&aggfns->xfn1,
(FmgrValues *) args, &isNull1);
pfree(oldVal); /* XXX - new, let's free the old datum - er1p */
Assert(!isNull1);
}
}