database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-04-27 22:56:53 +03:00
Code

Fix compiler warning in mul_var_short().

Browse Source 
Some compilers (e.g., gcc before version 7) mistakenly think "carry"
might be used uninitialized.

Reported by Tom Lane, per various buildfarm members, e.g. arowana.
This commit is contained in:
Dean Rasheed 2024-08-26 11:00:20 +01:00
parent 8daa62a10c
commit 7cac6307a4
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/backend/utils/adt/numeric.c
View File

@ -8969,7 +8969,7 @@ mul_var_short(const NumericVar *var1, const NumericVar *var2,
int res_ndigits; int res_ndigits;
NumericDigit *res_buf; NumericDigit *res_buf;
NumericDigit *res_digits; NumericDigit *res_digits;
uint32 carry; uint32 carry = 0;
uint32 term; uint32 term;
/* Check preconditions */ /* Check preconditions */
@ -9018,7 +9018,6 @@ mul_var_short(const NumericVar *var1, const NumericVar *var2,
* res_ndigits = var2ndigits + 1 * res_ndigits = var2ndigits + 1
* ---------- * ----------
*/ */
carry = 0;
for (int i = var2ndigits - 1; i >= 0; i--) for (int i = var2ndigits - 1; i >= 0; i--)
{ {
term = PRODSUM1(var1digits, 0, var2digits, i) + carry; term = PRODSUM1(var1digits, 0, var2digits, i) + carry;