database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-30 21:42:05 +03:00
Code Activity

Parse pg_ident.conf when it's loaded, keeping it in memory in parsed format.

Browse Source 
Similar changes were done to pg_hba.conf earlier already, this commit makes
pg_ident.conf to behave the same as pg_hba.conf.

This has two user-visible effects. First, if pg_ident.conf contains multiple
errors, the whole file is parsed at postmaster startup time and all the
errors are immediately reported. Before this patch, the file was parsed and
the errors were reported only when someone tries to connect using an
authentication method that uses the file, and the parsing stopped on first
error. Second, if you SIGHUP to reload the config files, and the new
pg_ident.conf file contains an error, the error is logged but the old file
stays in effect.

Also, regular expressions in pg_ident.conf are now compiled only once when
the file is loaded, rather than every time the a user is authenticated. That
should speed up authentication if you have a lot of regexps in the file.

Amit Kapila
This commit is contained in:
Heikki Linnakangas
2012-09-21 17:41:22 +03:00
parent 9d5e9730e5
commit 7c45e3a3c6
4 changed files with 216 additions and 97 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/backend/utils/init/postinit.c
View File

@ -197,7 +197,16 @@ PerformAuthentication(Port *port)
ereport(FATAL,
(errmsg("could not load pg_hba.conf")));
}
load_ident();
if (!load_ident())
{
/*
* It is ok to continue if we fail to load the IDENT file, although it
* means that you cannot log in using any of the authentication methods
* that need a user name mapping. load_ident() already logged the
* details of error to the log.
*/
}
#endif
/*