database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-18 17:42:25 +03:00
Code Activity

Prevent segfault in expand_tuple with no missing values

Browse Source 
Commit 16828d5c forgot to check that it had a set of missing values
before trying to retrieve a value from it.

An additional query to add coverage for this code is added to the
regression test.

Per bug report from Andreas Seltenreich.
This commit is contained in:
Andrew Dunstan
2018-04-13 16:43:33 -04:00
parent 8bf358c18e
commit 7c44c46deb
3 changed files with 50 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
src/test/regress/expected/fast_default.out
View File

@ -505,6 +505,41 @@ SELECT comp();
Unchanged
(1 row)
-- query to exercise expand_tuple function
CREATE TABLE t1 AS
SELECT 1::int AS a , 2::int AS b
FROM generate_series(1,20) q;
ALTER TABLE t1 ADD COLUMN c text;
SELECT a,
stddev(cast((SELECT sum(1) FROM generate_series(1,20) x) AS float4))
OVER (PARTITION BY a,b,c ORDER BY b)
AS z
FROM t1;
a | z
---+---
1 | 0
1 | 0
1 | 0
1 | 0
1 | 0
1 | 0
1 | 0
1 | 0
1 | 0
1 | 0
1 | 0
1 | 0
1 | 0
1 | 0
1 | 0
1 | 0
1 | 0
1 | 0
1 | 0
1 | 0
(20 rows)
DROP TABLE t1;
DROP TABLE T;
DROP FUNCTION set(name);
DROP FUNCTION comp();

14
src/test/regress/sql/fast_default.sql
View File

@ -347,6 +347,20 @@ SELECT c_text FROM T WHERE c_int = -1;
SELECT comp();
-- query to exercise expand_tuple function
CREATE TABLE t1 AS
SELECT 1::int AS a , 2::int AS b
FROM generate_series(1,20) q;
ALTER TABLE t1 ADD COLUMN c text;
SELECT a,
stddev(cast((SELECT sum(1) FROM generate_series(1,20) x) AS float4))
OVER (PARTITION BY a,b,c ORDER BY b)
AS z
FROM t1;
DROP TABLE t1;
DROP TABLE T;
DROP FUNCTION set(name);
DROP FUNCTION comp();