mirror of
https://github.com/postgres/postgres.git
synced 2025-07-09 22:41:56 +03:00
Fix up foreign-key mechanism so that there is a sound semantic basis for the
equality checks it applies, instead of a random dependence on whatever operators might be named "=". The equality operators will now be selected from the opfamily of the unique index that the FK constraint depends on to enforce uniqueness of the referenced columns; therefore they are certain to be consistent with that index's notion of equality. Among other things this should fix the problem noted awhile back that pg_dump may fail for foreign-key constraints on user-defined types when the required operators aren't in the search path. This also means that the former warning condition about "foreign key constraint will require costly sequential scans" is gone: if the comparison condition isn't indexable then we'll reject the constraint entirely. All per past discussions. Along the way, make the RI triggers look into pg_constraint for their information, instead of using pg_trigger.tgargs; and get rid of the always error-prone fixed-size string buffers in ri_triggers.c in favor of building up the RI queries in StringInfo buffers. initdb forced due to columns added to pg_constraint and pg_trigger.
This commit is contained in:
@ -3,7 +3,7 @@
|
||||
*
|
||||
* Copyright (c) 2000-2007, PostgreSQL Global Development Group
|
||||
*
|
||||
* $PostgreSQL: pgsql/src/bin/psql/describe.c,v 1.150 2007/01/20 21:17:30 neilc Exp $
|
||||
* $PostgreSQL: pgsql/src/bin/psql/describe.c,v 1.151 2007/02/14 01:58:58 tgl Exp $
|
||||
*/
|
||||
#include "postgres_fe.h"
|
||||
#include "describe.h"
|
||||
@ -1128,12 +1128,8 @@ describeOneTableDetails(const char *schemaname,
|
||||
"FROM pg_catalog.pg_trigger t\n"
|
||||
"WHERE t.tgrelid = '%s' "
|
||||
"AND t.tgenabled "
|
||||
"AND (NOT t.tgisconstraint "
|
||||
" OR NOT EXISTS"
|
||||
" (SELECT 1 FROM pg_catalog.pg_depend d "
|
||||
" JOIN pg_catalog.pg_constraint c ON (d.refclassid = c.tableoid AND d.refobjid = c.oid) "
|
||||
" WHERE d.classid = t.tableoid AND d.objid = t.oid AND d.deptype = 'i' AND c.contype = 'f'))"
|
||||
" ORDER BY 1",
|
||||
"AND t.tgconstraint = 0\n"
|
||||
"ORDER BY 1",
|
||||
oid);
|
||||
result4 = PSQLexec(buf.data, false);
|
||||
if (!result4)
|
||||
@ -1152,12 +1148,8 @@ describeOneTableDetails(const char *schemaname,
|
||||
"FROM pg_catalog.pg_trigger t\n"
|
||||
"WHERE t.tgrelid = '%s' "
|
||||
"AND NOT t.tgenabled "
|
||||
"AND (NOT t.tgisconstraint "
|
||||
" OR NOT EXISTS"
|
||||
" (SELECT 1 FROM pg_catalog.pg_depend d "
|
||||
" JOIN pg_catalog.pg_constraint c ON (d.refclassid = c.tableoid AND d.refobjid = c.oid) "
|
||||
" WHERE d.classid = t.tableoid AND d.objid = t.oid AND d.deptype = 'i' AND c.contype = 'f'))"
|
||||
" ORDER BY 1",
|
||||
"AND t.tgconstraint = 0\n"
|
||||
"ORDER BY 1",
|
||||
oid);
|
||||
result7 = PSQLexec(buf.data, false);
|
||||
if (!result7)
|
||||
|
Reference in New Issue
Block a user