database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-11-03 09:13:20 +03:00
Code Activity

Correct type of front_pathkey to PathKey

Browse Source 
In sort_inner_and_outer we iterate a list of PathKey elements, but the
variable is declared as (List *). This mistake is benign, because we
only pass the pointer to lcons() and never dereference it.

This exists since ~2004, but it's confusing. So fix and backpatch to all
supported branches.

Backpatch-through: 10
Discussion: https://postgr.es/m/bf3a6ea1-a7d8-7211-0669-189d5c169374%40enterprisedb.com
This commit is contained in:
Tomas Vondra
2022-01-23 03:36:55 +01:00
parent 6d554e3fcd
commit 7b65862e22
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/backend/optimizer/path/joinpath.c
View File

@@ -1258,7 +1258,7 @@ sort_inner_and_outer(PlannerInfo *root,
foreach(l, all_pathkeys) foreach(l, all_pathkeys)
{ {
List *front_pathkey = (List *) lfirst(l); PathKey *front_pathkey = (PathKey *) lfirst(l);
List *cur_mergeclauses; List *cur_mergeclauses;
List *outerkeys; List *outerkeys;
List *innerkeys; List *innerkeys;