mirror of
https://github.com/postgres/postgres.git
synced 2025-08-27 07:42:10 +03:00
Predict integer overflow to avoid buffer overruns.
Several functions, mostly type input functions, calculated an allocation size such that the calculation wrapped to a small positive value when arguments implied a sufficiently-large requirement. Writes past the end of the inadvertent small allocation followed shortly thereafter. Coverity identified the path_in() vulnerability; code inspection led to the rest. In passing, add check_stack_depth() to prevent stack overflow in related functions. Back-patch to 8.4 (all supported versions). The non-comment hstore changes touch code that did not exist in 8.4, so that part stops at 9.0. Noah Misch and Heikki Linnakangas, reviewed by Tom Lane. Security: CVE-2014-0064
This commit is contained in:
@@ -15,6 +15,8 @@
|
||||
#ifndef VARBIT_H
|
||||
#define VARBIT_H
|
||||
|
||||
#include <limits.h>
|
||||
|
||||
#include "fmgr.h"
|
||||
|
||||
/*
|
||||
@@ -53,6 +55,11 @@ typedef struct
|
||||
/* Number of bytes needed to store a bit string of a given length */
|
||||
#define VARBITTOTALLEN(BITLEN) (((BITLEN) + BITS_PER_BYTE-1)/BITS_PER_BYTE + \
|
||||
VARHDRSZ + VARBITHDRSZ)
|
||||
/*
|
||||
* Maximum number of bits. Several code sites assume no overflow from
|
||||
* computing bitlen + X; VARBITTOTALLEN() has the largest such X.
|
||||
*/
|
||||
#define VARBITMAXLEN (INT_MAX - BITS_PER_BYTE + 1)
|
||||
/* pointer beyond the end of the bit string (like end() in STL containers) */
|
||||
#define VARBITEND(PTR) (((bits8 *) (PTR)) + VARSIZE(PTR))
|
||||
/* Mask that will cover exactly one byte, i.e. BITS_PER_BYTE bits */
|
||||
|
Reference in New Issue
Block a user