From 77a3082fc546774808b76f58173caec3852ebf62 Mon Sep 17 00:00:00 2001 From: Alvaro Herrera Date: Thu, 31 Jan 2013 19:11:34 -0300 Subject: [PATCH] pgrowlocks: fix bogus lock strength output Per report from digoal@126.com --- contrib/pgrowlocks/pgrowlocks.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/contrib/pgrowlocks/pgrowlocks.c b/contrib/pgrowlocks/pgrowlocks.c index 43ada57352d..98aa7c80c08 100644 --- a/contrib/pgrowlocks/pgrowlocks.c +++ b/contrib/pgrowlocks/pgrowlocks.c @@ -247,7 +247,12 @@ pgrowlocks(PG_FUNCTION_ARGS) else if (HEAP_XMAX_IS_KEYSHR_LOCKED(infomask)) snprintf(values[Atnum_modes], NCHARS, "{For Key Share}"); else if (HEAP_XMAX_IS_EXCL_LOCKED(infomask)) - snprintf(values[Atnum_modes], NCHARS, "{For Update}"); + { + if (tuple->t_data->t_infomask2 & HEAP_KEYS_UPDATED) + snprintf(values[Atnum_modes], NCHARS, "{For Update}"); + else + snprintf(values[Atnum_modes], NCHARS, "{For No Key Update}"); + } else /* neither keyshare nor exclusive bit it set */ snprintf(values[Atnum_modes], NCHARS, @@ -256,9 +261,9 @@ pgrowlocks(PG_FUNCTION_ARGS) else { if (tuple->t_data->t_infomask2 & HEAP_KEYS_UPDATED) - snprintf(values[Atnum_modes], NCHARS, "{Key Update}"); - else snprintf(values[Atnum_modes], NCHARS, "{Update}"); + else + snprintf(values[Atnum_modes], NCHARS, "{No Key Update}"); } values[Atnum_pids] = palloc(NCHARS * sizeof(char));