1
0
mirror of https://github.com/postgres/postgres.git synced 2025-07-15 19:21:59 +03:00

Prevent regexp back-refs from sometimes matching when they shouldn't.

The recursion in cdissect() was careless about clearing match data
for capturing parentheses after rejecting a partial match.  This
could allow a later back-reference to succeed when by rights it
should fail for lack of a defined referent.

To fix, think a little more rigorously about what the contract
between different levels of cdissect's recursion needs to be.
With the right spec, we can fix this using fewer rather than more
resets of the match data; the key decision being that a failed
sub-match is now explicitly responsible for clearing any matches
it may have set.

There are enough other cross-checks and optimizations in the code
that it's not especially easy to exhibit this problem; usually, the
match will fail as-expected.  Plus, regexps that are even potentially
vulnerable are most likely user errors, since there's just not much
point in writing a back-ref that doesn't always have a referent.
These facts perhaps explain why the issue hasn't been detected,
even though it's almost certainly a couple of decades old.

Discussion: https://postgr.es/m/151435.1629733387@sss.pgh.pa.us
This commit is contained in:
Tom Lane
2021-08-23 17:41:07 -04:00
parent e3fb6170e5
commit 779557bd22
5 changed files with 69 additions and 8 deletions

View File

@ -2636,6 +2636,20 @@ select * from test_regex('^(.+)( \1)+$', 'abc abc abd', 'RP');
{2,REG_UBACKREF,REG_UNONPOSIX}
(1 row)
-- expectNomatch 14.30 RP {^(.)\1|\1.} {abcdef}
select * from test_regex('^(.)\1|\1.', 'abcdef', 'RP');
test_regex
--------------------------------
{1,REG_UBACKREF,REG_UNONPOSIX}
(1 row)
-- expectNomatch 14.31 RP {^((.)\2|..)\2} {abadef}
select * from test_regex('^((.)\2|..)\2', 'abadef', 'RP');
test_regex
--------------------------------
{2,REG_UBACKREF,REG_UNONPOSIX}
(1 row)
-- back reference only matches the string, not any constraints
select * from test_regex('(^\w+).*\1', 'abc abc abc', 'LRP');
test_regex