database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-05 07:21:24 +03:00
Code Activity

Move all extern declarations for GUC variables to header files

Browse Source 
Add extern declarations in appropriate header files for global
variables related to GUC.  In many cases, this was handled quite
inconsistently before, with some GUC variables declared in a header
file and some only pulled in via ad-hoc extern declarations in various
.c files.

Also add PGDLLIMPORT qualifications to those variables.  These were
previously missing because src/tools/mark_pgdllimport.pl has only been
used with header files.

This also fixes -Wmissing-variable-declarations warnings for GUC
variables (not yet part of the standard warning options).

Reviewed-by: Andres Freund <andres@anarazel.de>
Discussion: https://www.postgresql.org/message-id/flat/e0a62134-83da-4ba4-8cdb-ceb0111c95ce@eisentraut.org
This commit is contained in:
Peter Eisentraut
2024-07-24 06:21:39 +02:00
parent 991f8cf8ab
commit 774d47b6c0
12 changed files with 51 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/include/access/syncscan.h
View File

@ -17,6 +17,11 @@
#include "storage/block.h"
#include "utils/relcache.h"
/* GUC variables */
#ifdef TRACE_SYNCSCAN
extern PGDLLIMPORT bool trace_syncscan;
#endif
extern void ss_report_location(Relation rel, BlockNumber location);
extern BlockNumber ss_get_location(Relation rel, BlockNumber relnblocks);
extern void SyncScanShmemInit(void);

2
src/include/access/xlog.h
View File

@ -52,6 +52,8 @@ extern PGDLLIMPORT bool wal_recycle;
extern PGDLLIMPORT bool *wal_consistency_checking;
extern PGDLLIMPORT char *wal_consistency_checking_string;
extern PGDLLIMPORT bool log_checkpoints;
extern PGDLLIMPORT int CommitDelay;
extern PGDLLIMPORT int CommitSiblings;
extern PGDLLIMPORT bool track_wal_io_timing;
extern PGDLLIMPORT int wal_decode_buffer_size;

3
src/include/access/xlogutils.h
View File

@ -14,6 +14,9 @@
#include "access/xlogreader.h"
#include "storage/bufmgr.h"
/* GUC variable */
extern PGDLLIMPORT bool ignore_invalid_pages;
/*
* Prior to 8.4, all activity during recovery was carried out by the startup
* process. This local variable continues to be used in many parts of the