database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-04-27 22:56:53 +03:00
Code

Fix race in dsm_unpin_segment() when handles are reused.

Browse Source 
Teach dsm_unpin_segment() to skip segments that are in the process
of being destroyed by another backend, when searching for a handle.
Such a segment cannot possibly be the one we are looking for, even
if its handle matches.  Another slot might hold a recently created
segment that has the same handle value by coincidence, and we need
to keep searching for that one.

The bug caused rare "cannot unpin a segment that is not pinned"
errors on 10 and 11.  Similar to commit 6c0fb941 for dsm_attach().

Back-patch to 10, where dsm_unpin_segment() landed.

Author: Thomas Munro
Reported-by: Justin Pryzby
Tested-by: Justin Pryzby (along with other recent DSA/DSM fixes)
Discussion: https://postgr.es/m/20190216023854.GF30291@telsasoft.com
This commit is contained in:
Thomas Munro 2019-02-18 09:53:26 +13:00
parent c176997049
commit 7718a99203
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/backend/storage/ipc/dsm.c
View File

@ -904,8 +904,8 @@ dsm_unpin_segment(dsm_handle handle)
LWLockAcquire(DynamicSharedMemoryControlLock, LW_EXCLUSIVE); LWLockAcquire(DynamicSharedMemoryControlLock, LW_EXCLUSIVE);
for (i = 0; i < dsm_control->nitems; ++i) for (i = 0; i < dsm_control->nitems; ++i)
{ {
/* Skip unused slots. */ /* Skip unused slots and segments that are concurrently going away. */
if (dsm_control->item[i].refcnt == 0) if (dsm_control->item[i].refcnt <= 1)
continue; continue;
/* If we've found our handle, we can stop searching. */ /* If we've found our handle, we can stop searching. */