database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-03 20:02:46 +03:00
Code Activity

Reject out-of-range numeric timezone specifications.

Browse Source 
In commit 631dc390f4, we started to handle
simple numeric timezone offsets via the zic library instead of the old
CTimeZone/HasCTZSet kluge.  However, we overlooked the fact that the zic
code will reject UTC offsets exceeding a week (which seems a bit arbitrary,
but not because it's too tight ...).  This led to possibly setting
session_timezone to NULL, which results in crashes in most timezone-related
operations as of 9.4, and crashes in a small number of places even before
that.  So check for NULL return from pg_tzset_offset() and report an
appropriate error message.  Per bug #11014 from Duncan Gillis.

Back-patch to all supported branches, like the previous patch.
(Unfortunately, as of today that no longer includes 8.4.)
This commit is contained in:
Tom Lane
2014-07-21 22:41:27 -04:00
parent f7ba173cb3
commit 7672bbca0e
2 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/backend/commands/variable.c
View File

@ -373,6 +373,13 @@ check_timezone(char **newval, void **extra, GucSource source)
}
}
/* Test for failure in pg_tzset_offset, which we assume is out-of-range */
if (!myextra.session_timezone)
{
GUC_check_errdetail("UTC timezone offset is out of range.");
return false;
}
/*
* Prepare the canonical string to return. GUC wants it malloc'd.
*