From 766f7fd613adbceaf1b40803793e10dc487f8596 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Sun, 12 Mar 2017 16:01:33 -0400 Subject: [PATCH] Add "break"s to make it clearer what will happen in a nested switch. This could only matter if the guessed_type variable had a value that wasn't a member of the PasswordType enum; but just in case, let's be sure that control falls out to reach the elog(ERROR) at the end of the function. Per gripe from Coverity. --- src/backend/libpq/crypt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/backend/libpq/crypt.c b/src/backend/libpq/crypt.c index bd3e936d38c..9f0ae15b00e 100644 --- a/src/backend/libpq/crypt.c +++ b/src/backend/libpq/crypt.c @@ -162,6 +162,7 @@ encrypt_password(PasswordType target_type, const char *role, case PASSWORD_TYPE_MD5: return pstrdup(password); } + break; case PASSWORD_TYPE_SCRAM: switch (guessed_type) @@ -178,6 +179,7 @@ encrypt_password(PasswordType target_type, const char *role, case PASSWORD_TYPE_SCRAM: return pstrdup(password); } + break; } /*