database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-28 23:42:10 +03:00
Code Activity

Avoid a couple of zero-divide scenarios in the planner.

Browse Source 
cost_subplan() supposed that the given subplan must have plan_rows > 0,
which as far as I can tell was true until recent refactoring of the
code in createplan.c; but now that code allows the Result for a provably
empty subquery to have plan_rows = 0.  Rather than undo that change,
put in a clamp to prevent zero divide.

get_cheapest_fractional_path() likewise supposed that best_path->rows > 0.
This assumption has been wrong for longer.  It's actually harmless given
IEEE float math, because a positive value divided by zero gives +Infinity
and compare_fractional_path_costs() will do the right thing with that.
Still, best not to assume that.

final_cost_nestloop() also seems to have some risks in this area, so
borrow the clamping logic already present in the mergejoin cost functions.

Lastly, remove unnecessary clamp_row_est() in planner.c's calls to
get_number_of_groups().  The only thing that function does with path_rows
is pass it to estimate_num_groups() which already has an internal clamp,
so we don't need the extra call; and if we did, the callers are arguably
the wrong place for it anyway.

First two items reported by Piotr Stefaniak, the others are products
of my nosing around for similar problems.  No back-patch since there's
no evidence that problems arise in the back branches.
This commit is contained in:
Tom Lane
2016-03-26 12:03:12 -04:00
parent 676265eb7b
commit 76281aa964
2 changed files with 17 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/backend/optimizer/plan/planner.c
View File

@ -3346,12 +3346,10 @@ create_grouping_paths(PlannerInfo *root,
}
/*
* Estimate number of groups. Note: if cheapest_path is a dummy, it will
* have zero rowcount estimate, which we don't want to use for fear of
* divide-by-zero. Hence clamp.
* Estimate number of groups.
*/
dNumGroups = get_number_of_groups(root,
clamp_row_est(cheapest_path->rows),
cheapest_path->rows,
rollup_lists,
rollup_groupclauses);
@ -3415,7 +3413,7 @@ create_grouping_paths(PlannerInfo *root,
/* Estimate number of partial groups. */
dNumPartialGroups = get_number_of_groups(root,
clamp_row_est(cheapest_partial_path->rows),
cheapest_partial_path->rows,
NIL,
NIL);
@ -4840,8 +4838,8 @@ get_cheapest_fractional_path(RelOptInfo *rel, double tuple_fraction)
if (tuple_fraction <= 0.0)
return best_path;
/* Convert absolute # of tuples to a fraction; no need to clamp */
if (tuple_fraction >= 1.0)
/* Convert absolute # of tuples to a fraction; no need to clamp to 0..1 */
if (tuple_fraction >= 1.0 && best_path->rows > 0)
tuple_fraction /= best_path->rows;
foreach(l, rel->pathlist)