diff --git a/doc/src/sgml/client-auth.sgml b/doc/src/sgml/client-auth.sgml
index 9236fc014c4..36e5a5d9a86 100644
--- a/doc/src/sgml/client-auth.sgml
+++ b/doc/src/sgml/client-auth.sgml
@@ -1824,7 +1824,7 @@ host ... ldap ldapbasedn="dc=example,dc=net"
user name, password (encrypted) and
NAS Identifier. The request will be encrypted using
a secret shared with the server. The RADIUS server will respond to
- this server with either Access Accept or
+ this request with either Access Accept or
Access Reject. There is no support for RADIUS accounting.
@@ -1833,11 +1833,11 @@ host ... ldap ldapbasedn="dc=example,dc=net"
be tried sequentially. If a negative response is received from
a server, the authentication will fail. If no response is received,
the next server in the list will be tried. To specify multiple
- servers, put the names within quotes and separate the server names
- with a comma. If multiple servers are specified, all other RADIUS
- options can also be given as a comma separate list, to apply
- individual values to each server. They can also be specified as
- a single value, in which case this value will apply to all servers.
+ servers, separate the server names with commas and surround the list
+ with double quotes. If multiple servers are specified, the other
+ RADIUS options can also be given as comma-separated lists, to provide
+ individual values for each server. They can also be specified as
+ a single value, in which case that value will apply to all servers.
@@ -1847,7 +1847,7 @@ host ... ldap ldapbasedn="dc=example,dc=net"
radiusservers
- The name or IP addresses of the RADIUS servers to connect to.
+ The DNS names or IP addresses of the RADIUS servers to connect to.
This parameter is required.
@@ -1858,7 +1858,7 @@ host ... ldap ldapbasedn="dc=example,dc=net"
The shared secrets used when talking securely to the RADIUS
- server. This must have exactly the same value on the PostgreSQL
+ servers. This must have exactly the same value on the PostgreSQL
and RADIUS servers. It is recommended that this be a string of
at least 16 characters. This parameter is required.
@@ -1878,8 +1878,9 @@ host ... ldap ldapbasedn="dc=example,dc=net"
radiusports
- The port number on the RADIUS servers to connect to. If no port
- is specified, the default port 1812 will be used.
+ The port numbers to connect to on the RADIUS servers. If no port
+ is specified, the default RADIUS port (1812)
+ will be used.
@@ -1888,10 +1889,10 @@ host ... ldap ldapbasedn="dc=example,dc=net"
radiusidentifiers
- The string used as NAS Identifier in the RADIUS
- requests. This parameter can be used as a second parameter
- identifying for example which database user the user is attempting
- to authenticate as, which can be used for policy matching on
+ The strings to be used as NAS Identifier in the
+ RADIUS requests. This parameter can be used, for example, to
+ identify which database cluster the user is attempting to connect
+ to, which can be useful for policy matching on
the RADIUS server. If no identifier is specified, the default
postgresql will be used.
@@ -1900,6 +1901,16 @@ host ... ldap ldapbasedn="dc=example,dc=net"
+
+
+ If it is necessary to have a comma or whitespace in a RADIUS parameter
+ value, that can be done by putting double quotes around the value, but
+ it is tedious because two layers of double-quoting are now required.
+ An example of putting whitespace into RADIUS secret strings is:
+
+host ... radius radiusservers="server1,server2" radiussecrets="""secret one"",""secret two"""
+
+
diff --git a/src/backend/libpq/hba.c b/src/backend/libpq/hba.c
index 7f59a294a4d..cc4b661433f 100644
--- a/src/backend/libpq/hba.c
+++ b/src/backend/libpq/hba.c
@@ -1927,7 +1927,7 @@ parse_hba_auth_opt(char *name, char *val, HbaLine *hbaline,
REQUIRE_AUTH_OPTION(uaRADIUS, "radiusservers", "radius");
- if (!SplitIdentifierString(dupval, ',', &parsed_servers))
+ if (!SplitGUCList(dupval, ',', &parsed_servers))
{
/* syntax error in list */
ereport(elevel,
@@ -1976,7 +1976,7 @@ parse_hba_auth_opt(char *name, char *val, HbaLine *hbaline,
REQUIRE_AUTH_OPTION(uaRADIUS, "radiusports", "radius");
- if (!SplitIdentifierString(dupval, ',', &parsed_ports))
+ if (!SplitGUCList(dupval, ',', &parsed_ports))
{
ereport(elevel,
(errcode(ERRCODE_CONFIG_FILE_ERROR),
@@ -2011,7 +2011,7 @@ parse_hba_auth_opt(char *name, char *val, HbaLine *hbaline,
REQUIRE_AUTH_OPTION(uaRADIUS, "radiussecrets", "radius");
- if (!SplitIdentifierString(dupval, ',', &parsed_secrets))
+ if (!SplitGUCList(dupval, ',', &parsed_secrets))
{
/* syntax error in list */
ereport(elevel,
@@ -2033,7 +2033,7 @@ parse_hba_auth_opt(char *name, char *val, HbaLine *hbaline,
REQUIRE_AUTH_OPTION(uaRADIUS, "radiusidentifiers", "radius");
- if (!SplitIdentifierString(dupval, ',', &parsed_identifiers))
+ if (!SplitGUCList(dupval, ',', &parsed_identifiers))
{
/* syntax error in list */
ereport(elevel,