From 75f4ae2b8065ca7d29bec55f261828f794fbba1e Mon Sep 17 00:00:00 2001 From: Andrew Dunstan Date: Fri, 12 Jul 2024 18:29:15 -0400 Subject: [PATCH] Make sure to run pg_isready on correct port The current code can have pg_isready unexpectedly succeed if there is a server running on the default port. To avoid this we delay running the test until after a node has been created but before it starts, and then use that node's port, so we are fairly sure there is nothing running on the port. Backpatch to all live branches. --- src/bin/scripts/t/080_pg_isready.pl | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/bin/scripts/t/080_pg_isready.pl b/src/bin/scripts/t/080_pg_isready.pl index 8f53aef5737..d205ecadb2e 100644 --- a/src/bin/scripts/t/080_pg_isready.pl +++ b/src/bin/scripts/t/080_pg_isready.pl @@ -12,10 +12,11 @@ program_help_ok('pg_isready'); program_version_ok('pg_isready'); program_options_handling_ok('pg_isready'); -command_fails(['pg_isready'], 'fails with no server running'); - my $node = PostgreSQL::Test::Cluster->new('main'); $node->init; + +$node->command_fails(['pg_isready'], 'fails with no server running'); + $node->start; $node->command_ok(