database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-30 11:03:19 +03:00
Code Activity

Preserve pg_index.indisreplident across REINDEX CONCURRENTLY

Browse Source 
If the flag value is lost, logical decoding would work the same way as
REPLICA IDENTITY NOTHING, meaning that no old tuple values would be
included in the changes anymore produced by logical decoding.

Author: Michael Paquier
Reviewed-by: Euler Taveira
Discussion: https://postgr.es/m/20200603065340.GK89559@paquier.xyz
Backpatch-through: 12
This commit is contained in:
Michael Paquier
2020-06-05 10:29:27 +09:00
parent a958b07bc4
commit 75f1479240
3 changed files with 36 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/backend/catalog/index.c
View File

@ -1527,6 +1527,10 @@ index_concurrently_swap(Oid newIndexId, Oid oldIndexId, const char *oldName)
newIndexForm->indimmediate = oldIndexForm->indimmediate; newIndexForm->indimmediate = oldIndexForm->indimmediate;
oldIndexForm->indimmediate = true; oldIndexForm->indimmediate = true;
/* Preserve indisreplident in the new index */
newIndexForm->indisreplident = oldIndexForm->indisreplident;
oldIndexForm->indisreplident = false;
/* Preserve indisclustered in the new index */ /* Preserve indisclustered in the new index */
newIndexForm->indisclustered = oldIndexForm->indisclustered; newIndexForm->indisclustered = oldIndexForm->indisclustered;

21
src/test/regress/expected/create_index.out
View File

@ -2128,6 +2128,27 @@ SELECT indexrelid::regclass, indisclustered FROM pg_index
(1 row) (1 row)
DROP TABLE concur_clustered; DROP TABLE concur_clustered;
-- Check that indisreplident updates are preserved.
CREATE TABLE concur_replident(i int NOT NULL);
CREATE UNIQUE INDEX concur_replident_i_idx ON concur_replident(i);
ALTER TABLE concur_replident REPLICA IDENTITY
USING INDEX concur_replident_i_idx;
SELECT indexrelid::regclass, indisreplident FROM pg_index
WHERE indrelid = 'concur_replident'::regclass;
indexrelid | indisreplident
------------------------+----------------
concur_replident_i_idx | t
(1 row)
REINDEX TABLE CONCURRENTLY concur_replident;
SELECT indexrelid::regclass, indisreplident FROM pg_index
WHERE indrelid = 'concur_replident'::regclass;
indexrelid | indisreplident
------------------------+----------------
concur_replident_i_idx | t
(1 row)
DROP TABLE concur_replident;
-- Partitions -- Partitions
-- Create some partitioned tables -- Create some partitioned tables
CREATE TABLE concur_reindex_part (c1 int, c2 int) PARTITION BY RANGE (c1); CREATE TABLE concur_reindex_part (c1 int, c2 int) PARTITION BY RANGE (c1);

11
src/test/regress/sql/create_index.sql
View File

@ -860,6 +860,17 @@ REINDEX TABLE CONCURRENTLY concur_clustered;
SELECT indexrelid::regclass, indisclustered FROM pg_index SELECT indexrelid::regclass, indisclustered FROM pg_index
WHERE indrelid = 'concur_clustered'::regclass; WHERE indrelid = 'concur_clustered'::regclass;
DROP TABLE concur_clustered; DROP TABLE concur_clustered;
-- Check that indisreplident updates are preserved.
CREATE TABLE concur_replident(i int NOT NULL);
CREATE UNIQUE INDEX concur_replident_i_idx ON concur_replident(i);
ALTER TABLE concur_replident REPLICA IDENTITY
USING INDEX concur_replident_i_idx;
SELECT indexrelid::regclass, indisreplident FROM pg_index
WHERE indrelid = 'concur_replident'::regclass;
REINDEX TABLE CONCURRENTLY concur_replident;
SELECT indexrelid::regclass, indisreplident FROM pg_index
WHERE indrelid = 'concur_replident'::regclass;
DROP TABLE concur_replident;
-- Partitions -- Partitions
-- Create some partitioned tables -- Create some partitioned tables