mirror of
https://github.com/postgres/postgres.git
synced 2025-07-28 23:42:10 +03:00
Try another way to detect the result type of strerror_r().
The method we've traditionally used, of redeclaring strerror_r() to see if the compiler complains of inconsistent declarations, turns out not to work reliably because some compilers only report a warning, not an error. Amazingly, this has gone undetected for years, even though it certainly breaks our detection of whether strerror_r succeeded. Let's instead test whether the compiler will take the result of strerror_r() as a switch() argument. It's possible this won't work universally either, but it's the best idea I could come up with on the spur of the moment. We should probably back-patch this once the dust settles, but first let's see what the buildfarm thinks of it. Discussion: https://postgr.es/m/10877.1537993279@sss.pgh.pa.us
This commit is contained in:
10
configure
vendored
10
configure
vendored
@ -10792,12 +10792,10 @@ else
|
||||
int
|
||||
main ()
|
||||
{
|
||||
#ifndef _AIX
|
||||
int strerror_r(int, char *, size_t);
|
||||
#else
|
||||
/* Older AIX has 'int' for the third argument so we don't test the args. */
|
||||
int strerror_r();
|
||||
#endif
|
||||
char buf[100];
|
||||
switch (strerror_r(1, buf, sizeof(buf)))
|
||||
{ case 0: break; default: break; }
|
||||
|
||||
;
|
||||
return 0;
|
||||
}
|
||||
|
Reference in New Issue
Block a user