database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-11-18 02:02:55 +03:00
Code Activity

Add note about CreateStatistics()'s selective use of check_rights.

Browse Source 
Commit 5e4fcbe531 added a check_rights parameter to this function
for use by ALTER TABLE commands that re-create statistics objects.
However, we intentionally ignore check_rights when verifying
relation ownership because this function's lookup could return a
different answer than the caller's.  This commit adds a note to
this effect so that we remember it down the road.

Reviewed-by: Noah Misch <noah@leadboat.com>
Backpatch-through: 14
This commit is contained in:
Nathan Bossart
2025-11-14 13:20:09 -06:00
parent 4c00960772
commit 7506bdbbf4
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/backend/commands/statscmds.c
View File

@@ -135,7 +135,13 @@ CreateStatistics(CreateStatsStmt *stmt, bool check_rights)
RelationGetRelationName(rel)), RelationGetRelationName(rel)),
errdetail_relkind_not_supported(rel->rd_rel->relkind))); errdetail_relkind_not_supported(rel->rd_rel->relkind)));
/* You must own the relation to create stats on it */ /*
* You must own the relation to create stats on it.
*
* NB: Concurrent changes could cause this function's lookup to find a
* different relation than a previous lookup by the caller, so we must
* perform this check even when check_rights == false.
*/
if (!object_ownercheck(RelationRelationId, RelationGetRelid(rel), stxowner)) if (!object_ownercheck(RelationRelationId, RelationGetRelid(rel), stxowner))
aclcheck_error(ACLCHECK_NOT_OWNER, get_relkind_objtype(rel->rd_rel->relkind), aclcheck_error(ACLCHECK_NOT_OWNER, get_relkind_objtype(rel->rd_rel->relkind),
RelationGetRelationName(rel)); RelationGetRelationName(rel));