database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-09 22:41:56 +03:00
Code Activity

Removal unused function parameter in CopyReadBinaryAttribute.

Browse Source 
The function parameter column_no is not used in CopyReadBinaryAttribute,
this can be removed.

Commit 0e319c7ad7 removed the usage of column_no parameter in function
CopyReadBinaryAttribute but forgot to remove the parameter.

Reported-by: Vignesh C
Author: Vignesh C
Discussion: https://postgr.es/m/CALDaNm1TYSNTfqx_jfz9_mwEZ2Er=dZnu++duXpC1uQo1cG=WA@mail.gmail.com
This commit is contained in:
Amit Kapila
2020-06-20 09:18:57 +05:30
parent ae3259c550
commit 74b4d78e03
1 changed files with 2 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/backend/commands/copy.c
View File

@ -367,8 +367,7 @@ static bool CopyReadLine(CopyState cstate);
static bool CopyReadLineText(CopyState cstate); static bool CopyReadLineText(CopyState cstate);
static int CopyReadAttributesText(CopyState cstate); static int CopyReadAttributesText(CopyState cstate);
static int CopyReadAttributesCSV(CopyState cstate); static int CopyReadAttributesCSV(CopyState cstate);
static Datum CopyReadBinaryAttribute(CopyState cstate, static Datum CopyReadBinaryAttribute(CopyState cstate, FmgrInfo *flinfo,
int column_no, FmgrInfo *flinfo,
Oid typioparam, int32 typmod, Oid typioparam, int32 typmod,
bool *isnull); bool *isnull);
static void CopyAttributeOutText(CopyState cstate, char *string); static void CopyAttributeOutText(CopyState cstate, char *string);
@ -3776,7 +3775,6 @@ NextCopyFrom(CopyState cstate, ExprContext *econtext,
errmsg("row field count is %d, expected %d", errmsg("row field count is %d, expected %d",
(int) fld_count, attr_count))); (int) fld_count, attr_count)));
i = 0;
foreach(cur, cstate->attnumlist) foreach(cur, cstate->attnumlist)
{ {
int attnum = lfirst_int(cur); int attnum = lfirst_int(cur);
@ -3784,9 +3782,7 @@ NextCopyFrom(CopyState cstate, ExprContext *econtext,
Form_pg_attribute att = TupleDescAttr(tupDesc, m); Form_pg_attribute att = TupleDescAttr(tupDesc, m);
cstate->cur_attname = NameStr(att->attname); cstate->cur_attname = NameStr(att->attname);
i++;
values[m] = CopyReadBinaryAttribute(cstate, values[m] = CopyReadBinaryAttribute(cstate,
i,
&in_functions[m], &in_functions[m],
typioparams[m], typioparams[m],
att->atttypmod, att->atttypmod,
@ -4714,8 +4710,7 @@ endfield:
* Read a binary attribute * Read a binary attribute
*/ */
static Datum static Datum
CopyReadBinaryAttribute(CopyState cstate, CopyReadBinaryAttribute(CopyState cstate, FmgrInfo *flinfo,
int column_no, FmgrInfo *flinfo,
Oid typioparam, int32 typmod, Oid typioparam, int32 typmod,
bool *isnull) bool *isnull)
{ {