database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-12-04 12:02:48 +03:00
Code Activity

Disable installcheck tests for test_session_hooks

Browse Source 
The module requires a preloaded library and the defect can't be cured by
a LOAD instruction in the test script. To achieve this we override the
installcheck target in the module's Makefile, and exclude ithe module in
vcregress.pl.

Along the way, revert commit 9989f92aab.
This commit is contained in:
Andrew Dunstan
2017-11-15 17:49:04 -05:00
parent 9989f92aab
commit 745948422c
3 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/test/modules/Makefile
View File

@@ -15,6 +15,7 @@ SUBDIRS = \
test_pg_dump \ test_pg_dump \
test_rbtree \ test_rbtree \
test_rls_hooks \ test_rls_hooks \
test_session_hooks \
test_shm_mq \ test_shm_mq \
worker_spi worker_spi

4
src/test/modules/test_session_hooks/Makefile
View File

@@ -19,3 +19,7 @@ top_builddir = ../../../..
include $(top_builddir)/src/Makefile.global include $(top_builddir)/src/Makefile.global
include $(top_srcdir)/contrib/contrib-global.mk include $(top_srcdir)/contrib/contrib-global.mk
endif endif
# override installcheck - this module requires preloading the test module
installcheck:
@echo Cannot run $@ for test_session_hooks. Run "'make check'" instead.

2
src/tools/msvc/vcregress.pl
View File

@@ -383,6 +383,8 @@ sub modulescheck
my $mstat = 0; my $mstat = 0;
foreach my $module (glob("*")) foreach my $module (glob("*"))
{ {
# test_session_hooks can't run installcheck, so skip it here
next if $module eq 'test_session_hooks';
subdircheck("$topdir/src/test/modules", $module); subdircheck("$topdir/src/test/modules", $module);
my $status = $? >> 8; my $status = $? >> 8;
$mstat ||= $status; $mstat ||= $status;