database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-08 11:42:09 +03:00
Code Activity

Code cleanup for heap_freeze_tuple.

Browse Source 
It used to be case that lazy vacuum could call this function with only
a shared lock on the buffer, but neither lazy vacuum nor any other
code path does that any more.  Simplify the code accordingly and clean
up some related, obsolete comments.
This commit is contained in:
Robert Haas
2012-03-26 11:03:06 -04:00
parent e8476f46fc
commit 7386089d23
4 changed files with 7 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/backend/access/heap/rewriteheap.c
View File

@ -335,13 +335,8 @@ rewrite_heap_tuple(RewriteState state,
/*
* While we have our hands on the tuple, we may as well freeze any
* very-old xmin or xmax, so that future VACUUM effort can be saved.
*
* Note we abuse heap_freeze_tuple() a bit here, since it's expecting to
* be given a pointer to a tuple in a disk buffer. It happens though that
* we can get the right things to happen by passing InvalidBuffer for the
* buffer.
*/
heap_freeze_tuple(new_tuple->t_data, state->rs_freeze_xid, InvalidBuffer);
heap_freeze_tuple(new_tuple->t_data, state->rs_freeze_xid);
/*
* Invalid ctid means that ctid should point to the tuple itself. We'll