database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-24 14:22:24 +03:00
Code Activity

Add errno value for thread *_r function call buffer too small. Improve

Browse Source 
thread comments.
This commit is contained in:
Bruce Momjian
2003-09-15 02:30:29 +00:00
parent 24d41a9efc
commit 72ed916a1f
1 changed files with 14 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/port/thread.c
View File

@ -7,7 +7,7 @@
* *
* Portions Copyright (c) 1996-2003, PostgreSQL Global Development Group * Portions Copyright (c) 1996-2003, PostgreSQL Global Development Group
* *
* $Id: thread.c,v 1.7 2003/09/13 14:49:51 momjian Exp $ * $Id: thread.c,v 1.8 2003/09/15 02:30:29 momjian Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
@ -17,6 +17,7 @@
#include <pthread.h> #include <pthread.h>
#include <sys/types.h> #include <sys/types.h>
#include <pwd.h> #include <pwd.h>
#include <errno.h>
/* /*
* Threading sometimes requires specially-named versions of functions * Threading sometimes requires specially-named versions of functions
@ -48,6 +49,12 @@
* use *_r functions if they exist (configure test) * use *_r functions if they exist (configure test)
* do our own locking and copying of non-threadsafe functions * do our own locking and copying of non-threadsafe functions
* *
* The disadvantage of the last option is not the thread overhead but
* the fact that all function calls are serialized, and with gethostbyname()
* requiring a DNS lookup, that could be slow.
*
* One thread-safe solution for gethostbyname() might be to use getaddrinfo().
*
* Compile and run src/tools/test_thread_funcs.c to see if your operating * Compile and run src/tools/test_thread_funcs.c to see if your operating
* system has thread-safe non-*_r functions. * system has thread-safe non-*_r functions.
*/ */
@ -143,7 +150,10 @@ pqGetpwuid(uid_t uid, struct passwd *resultbuf, char *buffer,
*result = resultbuf; *result = resultbuf;
} }
else else
{
*result = NULL; *result = NULL;
errno = ERANGE;
}
pthread_mutex_unlock(&getpwuid_lock); pthread_mutex_unlock(&getpwuid_lock);
#endif #endif
@ -239,7 +249,10 @@ pqGethostbyname(const char *name,
*result = resultbuf; *result = resultbuf;
} }
else else
{
*result = NULL; *result = NULL;
errno = ERANGE;
}
} }
#endif #endif