database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-29 10:41:53 +03:00
Code Activity

Prevent creating window functions with default arguments.

Browse Source 
Insertion of default arguments doesn't work for window functions, which is
likely to cause a crash at runtime if the implementation code doesn't check
the number of actual arguments carefully.  It doesn't seem worth working
harder than this for pre-9.2 branches.
This commit is contained in:
Tom Lane
2013-11-06 13:32:36 -05:00
parent 2268d1c14c
commit 72c8a584bf
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/backend/catalog/pg_proc.c
View File

@ -283,6 +283,12 @@ ProcedureCreate(const char *procedureName,
} }
} }
/* Guard against a case the planner doesn't handle yet */
if (isWindowFunc && parameterDefaults != NIL)
ereport(ERROR,
(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
errmsg("window functions cannot have default arguments")));
/* /*
* All seems OK; prepare the data to be inserted into pg_proc. * All seems OK; prepare the data to be inserted into pg_proc.
*/ */